Re: [PATCH v2 1/5] treewide: use prandom_u32_max() when possible

From: Jan Kara
Date: Thu Oct 06 2022 - 12:25:04 EST

On Thu 06-10-22 07:25:06, Jason A. Donenfeld wrote:
> Rather than incurring a division or requesting too many random bytes for
> the given range, use the prandom_u32_max() function, which only takes
> the minimum required bytes from the RNG and avoids divisions.
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Reviewed-by: KP Singh <kpsingh@xxxxxxxxxx>
> Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

for the ext2, ext4, and lib/sbitmap.c bits.

Jan Kara <jack@xxxxxxxx>