Re: [PATCHv4 0/8] Virtual NMI feature

From: Sean Christopherson
Date: Thu Oct 06 2022 - 14:40:49 EST

On Mon, Aug 29, 2022, Santosh Shukla wrote:
> If NMI virtualization enabled and NMI_INTERCEPT bit is unset
> then HW will exit with #INVALID exit reason.
> To enable the VNMI capability, Hypervisor need to program
> V_NMI_ENABLE bit 1.
> The presence of this feature is indicated via the CPUID function
> 0x8000000A_EDX[25].

Until there is publicly available documentation, I am not going to review this
any further. This goes for all new features, e.g. PerfMonv2[*]. I understand
the need and desire to get code merged far in advance of hardware being available,
but y'all clearly have specs, i.e. this is a very solvable problem. Throw all the
disclaimers you want on the specs to make it abundantly clear that they are for
preview purposes or whatever, but reviewing KVM code without a spec just doesn't
work for me.