Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup

[Juergen Gross]

On 06.10.22 18:35, Oleksandr Tyshchenko wrote:
> On 06.10.22 10:14, Juergen Gross wrote:
>
> Hello Juergen
>
> > In order to prepare supporting other means than device tree for
> > setting up virtio devices under Xen, restructure the functions
> > xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
>
> Patch looks good,
>
> one NIT, xen_dt_grant_setup_dma_ops() down the code doesn't actually
> setup DMA OPS, it retrieves the backend domid via device-tree means and
> stores it,
>
> so I would rename to it, maybe something like
> xen_dt_grant_setup_backend_domid() or xen_dt_grant_init_backend_domid(),
> but I am not sure it would be good alternative.

I'll go with xen_dt_grant_init_backend_domid().

> So, w/ or w/o renaming:
>
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> also
>
> Tested-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> # Arm64
> only

Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature