Re: [RESEND PATCH v3 2/4] leds: class: store the color index in struct led_classdev

From: Jean-Jacques Hiblot
Date: Fri Oct 07 2022 - 02:35:43 EST

On 17/09/2022 10:40, Andy Shevchenko wrote:
On Sat, Sep 17, 2022 at 11:14 AM Jean-Jacques Hiblot
<jjhiblot@xxxxxxxxxxxxxxx> wrote:
This information might be useful for more than only deriving the led's

+ if (fwnode_property_present(init_data->fwnode, "color"))
+ fwnode_property_read_u32(init_data->fwnode, "color",
+ &led_cdev->color);
Is it already described in the schema?

Hello Andy,

thanks for the reviews on the patch, and sorry for the delay in my responses.

Yes. This is already part of the schema.

unsigned int brightness;
unsigned int max_brightness;
+ unsigned int color;
The above two are exposed via sysfs, do you need to expose a new one
as well? (Just a question, I am not taking any side here, want to hear
explanation of the either choice)

I didn't really think about it because I didn't need it.

It probably doesn't hurt to expose t in the sysfs. I'll add this in the next round.