Re: [f2fs-dev] [PATCH v4 1/2] f2fs: correct i_size change for atomic writes

From: Chao Yu
Date: Fri Oct 07 2022 - 10:43:03 EST


On 2022/10/7 22:22, Daeho Jeong wrote:

Fine to me.

But another question is, now it allows GC to migrate blocks belong
to atomic files, so, during migration, it may update extent cache,
once largest extent was updated, it will mark inode dirty, but after
this patch, it may lose the extent change? thoughts?


Oh, I missed that case. Maybe we could prevent updating the i_size of
atomic files in f2fs_update_inode() while allowing inode dirtying.

Agreed. :)

Thanks,