Re: [bpf-next v7 1/3] bpftool: Add auto_attach for bpf prog load|loadall

[wangyufen]

在 2022/10/1 4:55, Andrii Nakryiko 写道:
> On Tue, Sep 27, 2022 at 4:00 AM Wang Yufen <wangyufen@xxxxxxxxxx> wrote:
> > Add auto_attach optional to support one-step load-attach-pin_link.
> >
> > For example,
> >     $ bpftool prog loadall test.o /sys/fs/bpf/test autoattach
> >
> >     $ bpftool link
> >     26: tracing  name test1  tag f0da7d0058c00236  gpl
> >          loaded_at 2022-09-09T21:39:49+0800  uid 0
> >          xlated 88B  jited 55B  memlock 4096B  map_ids 3
> >          btf_id 55
> >     28: kprobe  name test3  tag 002ef1bef0723833  gpl
> >          loaded_at 2022-09-09T21:39:49+0800  uid 0
> >          xlated 88B  jited 56B  memlock 4096B  map_ids 3
> >          btf_id 55
> >     57: tracepoint  name oncpu  tag 7aa55dfbdcb78941  gpl
> >          loaded_at 2022-09-09T21:41:32+0800  uid 0
> >          xlated 456B  jited 265B  memlock 4096B  map_ids 17,13,14,15
> >          btf_id 82
> >
> >     $ bpftool link
> >     1: tracing  prog 26
> >          prog_type tracing  attach_type trace_fentry
> >     3: perf_event  prog 28
> >     10: perf_event  prog 57
> >
> > The autoattach optional can support tracepoints, k(ret)probes,
> > u(ret)probes.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > Signed-off-by: Wang Yufen <wangyufen@xxxxxxxxxx>
> > ---
> For next revision, please also attach cover letter describing the
> overall goal of the patch set (and that's where the version log
> between revisions is put as well).

Thanks, will add a cover letter in v8.

> > v6 -> v7: add info msg print and update doc for the skip program
> > v5 -> v6: skip the programs not supporting auto-attach,
> >            and change optional name from "auto_attach" to "autoattach"
> > v4 -> v5: some formatting nits of doc
> > v3 -> v4: rename functions, update doc, bash and do_help()
> > v2 -> v3: switch to extend prog load command instead of extend perf
> > v2: https://patchwork.kernel.org/project/netdevbpf/patch/20220824033837.458197-1-weiyongjun1@xxxxxxxxxx/
> > v1: https://patchwork.kernel.org/project/netdevbpf/patch/20220816151725.153343-1-weiyongjun1@xxxxxxxxxx/
> >   tools/bpf/bpftool/prog.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++--
> >   1 file changed, 79 insertions(+), 2 deletions(-)
> [...]