Re: [PATCH 1/3] ipmi: fix msg stack when IPMI is disconnected

From: Corey Minyard
Date: Sat Oct 08 2022 - 07:49:14 EST


On Sat, Oct 08, 2022 at 09:36:16AM +0800, Yuchen Zhang wrote:
> > Also, the following is in start_kcs_transaction():
> >
> > if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
> > dev_warn(kcs->io->dev, "KCS in invalid state %d\n", kcs->state);
> > return IPMI_NOT_IN_MY_STATE_ERR;
> > }
> >
> > You probably need to remove the (kcs->state != KCS_HOSED) part of this
> > now. Would you agree?
> >
> > -corey
> >
> I agree. KCS_HOSED state should be an invalid state.

Can you make this change, run a quick test, and re-submit this one
patch? With that, I can include this.

Thanks,

-corey