Re: [PATCH] docs: ftrace: Correct access mode

From: Steven Rostedt
Date: Sat Oct 08 2022 - 16:19:57 EST


On Sat, 8 Oct 2022 08:32:50 +0000
Leo Yan <leo.yan@xxxxxxxxxx> wrote:

> The documentation gives an example for opening trace marker with
> write-only mode, but the flag WR_ONLY is not defined by glibc.
>
> Use O_WRONLY to replace it.
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> ---
> Documentation/trace/ftrace.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index b37dc19e4d40..60bceb018d6a 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -564,7 +564,7 @@ of ftrace. Here is a list of some of the key files:
>
> start::
>
> - trace_fd = open("trace_marker", WR_ONLY);
> + trace_fd = open("trace_marker", O_WRONLY);

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve

>
> Note: Writing into the trace_marker file can also initiate triggers
> that are written into /sys/kernel/tracing/events/ftrace/print/trigger