Re: [PATCH] drm/tve200: Use drm_* variants for logging
From: Khalid Masum
Date: Sat Oct 08 2022 - 22:15:22 EST
On Tue, Oct 4, 2022 at 12:54 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Wed, Sep 28, 2022 at 11:31 AM Khalid Masum <khalid.masum.92@xxxxxxxxx> wrote:
>
> > We have routines like drm_info/warn/err for logging. Use them instead
> > of dev_* variants to get drm-formatted log messages.
> >
> > Signed-off-by: Khalid Masum <khalid.masum.92@xxxxxxxxx>
>
> So is this the new thing? We've been through:
> - DRM_INFO_ETC BIG CAPITAL LETTER MACROS
> - Just use dev_info() & friends like everyone else
> - Now drm_info() & co
>
> Note I don't wanna bikeshed about this, just tell me there is
> consensus now so we know what to do.
Hi,
I was working on a TODO described here:
https://github.com/torvalds/linux/blob/master/Documentation/gpu/todo.rst#convert-logging-to-drm_-functions-with-drm_device-paramater
"Convert logging to drm_* functions with drm_device paramater". I do not
know of any consensus by the way.
>
> Yours,
> Linus Walleij
Thanks,
-- Khalid Masum