Re: Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot

[Kees Cook]

On Sat, Oct 08, 2022 at 09:41:59PM +0800, Li Zetao wrote:
> On 2022/9/30 11:27, Li Zetao wrote:
> > This series removes some unused variables in x86/boot, and add the
> > "-Wall" flag to Makefile, which is the old problem of x86 not sharing
> > makefiles.
> > 
> > Changes since v2:
> > - Add "frame-address" flag and "-std=gnu11" to
> >    x86/boot/compressed/Makefile to fix warnings when "-Wall" flag added.
> > - Declare the variable "i" within the for loop to reslove unused
> >    variable warning.
> > - Delete __efi_get_rsdp_addr function when CONFIG_EFI is disabled to
> >    resolve unused function warning.

Nathan suggested earlier (and I agree): please re-order these patches so
the fixes for the new warnings are first, and then turn on the compiler
flags in a final patch. This will keep the build "warning free" at all
steps.

-- 
Kees Cook