Re: [PATCH] mISDN: hfcpci: Fix use-after-free bug in hfcpci_softirq

From: patchwork-bot+netdevbpf
Date: Sun Oct 09 2022 - 15:00:26 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Sun, 9 Oct 2022 14:37:31 +0800 you wrote:
> The function hfcpci_softirq() is a timer handler. If it
> is running, the timer_pending() will return 0 and the
> del_timer_sync() in HFC_cleanup() will not be executed.
> As a result, the use-after-free bug will happen. The
> process is shown below:
>
> (cleanup routine) | (timer handler)
> HFC_cleanup() | hfcpci_softirq()
> if (timer_pending(&hfc_tl)) |
> del_timer_sync() |
> ... | ...
> pci_unregister_driver(hc) |
> driver_unregister | driver_for_each_device
> bus_remove_driver | _hfcpci_softirq
> driver_detach | ...
> put_device(dev) //[1]FREE |
> | dev_get_drvdata(dev) //[2]USE
>
> [...]

Here is the summary with links:
- mISDN: hfcpci: Fix use-after-free bug in hfcpci_softirq
https://git.kernel.org/netdev/net/c/175302f6b79e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html