Re: [PATCH V2] PCI: dwc: Fix n_fts[] array overrun

[Vidya Sagar]

Hi Lorenzo,
Do you have any further comments for this patch?

Thanks,
Vidya Sagar

On 10/5/2022 3:20 AM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, Sep 26, 2022 at 6:19 AM Vidya Sagar <vidyas@xxxxxxxxxx> wrote:
> > commit aeaa0bfe89654 ("PCI: dwc: Move N_FTS setup to common setup")
> > incorrectly uses pci->link_gen in deriving the index to the
> > n_fts[] array also introducing the issue of accessing beyond the
> > boundaries of array for greater than Gen-2 speeds. This change fixes
> > that issue.
> >
> > Fixes: aeaa0bfe8965 ("PCI: dwc: Move N_FTS setup to common setup")
> > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> > Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx>
> > ---
> > V2:
> > * Addressed review comments from Bjorn
> > * Added "Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx>"
> >
> >   drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>