Re: PING: [PATCH] platform: use fwnode_irq_get_byname instead of of_irq_get_byname to get irq

[Greg KH]

On Mon, Oct 10, 2022 at 11:14:46AM +0800, Soha Jin wrote:
> > -----Original Message-----
> > From: soha@xxxxxxxxx <soha@xxxxxxxxx>
> > Sent: Saturday, October 1, 2022 2:15 AM
> > To: gregkh@xxxxxxxxxxxxxxxxxxx
> > Cc: rafael@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 'Wende Tan'
> > <twd2.me@xxxxxxxxx>
> > Subject: [PATCH] platform: use fwnode_irq_get_byname instead of
> > of_irq_get_byname to get irq
> > 
> > >From 02df97f4d814b9893eef2c2118b85d2b4b9d61ae Mon Sep 17
> > 00:00:00 2001
> > From: Soha Jin <soha@xxxxxxxxx>
> > Date: Sat, 1 Oct 2022 00:26:04 +0800
> > Subject: [PATCH] platform: use fwnode_irq_get_byname instead of
> > of_irq_get_byname to get irq
> > 
> > Not only platform devices described by OF have named interrupts, but
> > devices described by ACPI also have named interrupts. The fwnode is an
> > abstraction to different standards, and using fwnode_irq_get_byname can
> > support more devices.
> > 
> > Signed-off-by: Soha Jin <soha@xxxxxxxxx>
> > Tested-by: Wende Tan <twd2.me@xxxxxxxxx>
> > ---
> >  drivers/base/platform.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c index
> > 51bb22898..968f3d71e 100644
> > --- a/drivers/base/platform.c
> > +++ b/drivers/base/platform.c
> > @@ -441,8 +441,8 @@ static int __platform_get_irq_byname(struct
> > platform_device *dev,
> >  	struct resource *r;
> >  	int ret;
> > 
> > -	if (IS_ENABLED(CONFIG_OF_IRQ) && dev->dev.of_node) {
> > -		ret = of_irq_get_byname(dev->dev.of_node, name);
> > +	if (!dev->dev.of_node || IS_ENABLED(CONFIG_OF_IRQ)) {
> > +		ret = fwnode_irq_get_byname(dev_fwnode(&dev->dev), name);
> >  		if (ret > 0 || ret == -EPROBE_DEFER)
> >  			return ret;
> >  	}
> > --
> > 2.30.2
> > 
> > 
> 
> Any updates on this 10-day-ago patch?

It's the middle of the merge window, we can't do anything until after
6.1-rc1 is out, please relax and wait for that.

And what is the rush here, what is broken without this change?

thanks,

greg k-h