Re: [PATCH v1 1/1] mfd: syscon: Remove repetition of the regmap_get_val_endian()
From: Andy Shevchenko
Date: Mon Oct 10 2022 - 02:50:04 EST
On Sun, Oct 09, 2022 at 09:39:42AM -0700, Guenter Roeck wrote:
> On Mon, Aug 08, 2022 at 05:08:11PM +0300, Andy Shevchenko wrote:
> > Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness
> > definitions from DT") regmap MMIO parses DT itsef, no need to
> > repeat this in the caller(s).
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> This patch results in reboot failures for all big endian mips emulations.
>
> Sample log:
>
> Network interface test passed
> Boot successful.
> Rebooting
> reboot: Restarting system
> Unable to restart system
> Reboot failed -- System halted
>
> The problem is not seen with little endian mips emulations. Reverting
> this patch fixes the problem. Bisect log attached.
>
> #regzbot introduced: 72a95859728a
> #regzbot title: Reboot failure on big endian mips systems
Right, Jason sent a revert already, but Linus asked for the proper submission.
--
With Best Regards,
Andy Shevchenko