Re: [PATCH v3 09/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6735 pin controller

[Krzysztof Kozlowski]

On 07/10/2022 08:59, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> 
> Add bindings for the pin controller found on MediaTek MT6735 and
> MT6735M SoCs, including describing a method to manually specify
> a pin and function in the pinmux property making defining bindings
> for each pin/function combination unnecessary. The pin controllers
> on those SoCs are generally identical, with the only difference
> being the lack of MSDC2 pins (198-203) on MT6735M.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  .../pinctrl/mediatek,mt6779-pinctrl.yaml      | 46 ++++++++++++++++++-
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 51 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> index 71a9aae2cc8c..7b120803a1a5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> @@ -10,6 +10,7 @@ maintainers:
>    - Andy Teng <andy.teng@xxxxxxxxxxxx>
>    - AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>    - Sean Wang <sean.wang@xxxxxxxxxx>
> +  - Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
>  
>  description:
>    The MediaTek pin controller on MT6779 is used to control pin
> @@ -18,6 +19,8 @@ description:
>  properties:
>    compatible:
>      enum:
> +      - mediatek,mt6735-pinctrl
> +      - mediatek,mt6735m-pinctrl
>        - mediatek,mt6765-pinctrl
>        - mediatek,mt6779-pinctrl
>        - mediatek,mt6795-pinctrl
> @@ -63,6 +66,33 @@ required:
>  
>  allOf:
>    - $ref: "pinctrl.yaml#"
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt6735-pinctrl
> +              - mediatek,mt6735m-pinctrl
> +    then:
> +      properties:
> +        reg:
> +          minItems: 8
> +          maxItems: 8
> +
> +        reg-names:
> +          items:
> +            - const: gpio
> +            - const: iocfg0
> +            - const: iocfg1
> +            - const: iocfg2
> +            - const: iocfg3
> +            - const: iocfg4
> +            - const: iocfg5
> +            - const: eint
> +
> +        interrupts:
> +          items:
> +            - description: EINT interrupt

Blank line

Best regards,
Krzysztof