Re: [PATCH v3 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count

[AngeloGioacchino Del Regno]

Il 10/10/22 13:13, Krzysztof Kozlowski ha scritto:
> On 07/10/2022 08:58, Yassine Oudjana wrote:
> > From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> >
> > The document currently states a maximum of 1 interrupt, but the DT
> > has 2 specified causing a dtbs_check error. Replace the maximum limit
> > with a minimum and add per-interrupt descriptions to pass the check.
> >
> > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > index 73ae6e11410b..a3a3f7fb9605 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > @@ -47,7 +47,10 @@ properties:
> >   
> >     interrupts:
> >       description: The interrupt outputs to sysirq.
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: EINT interrupt
> > +      - description: EINT event_b interrupt
>
> Is second interrupt really optional or you just wanted to silence the
> warning?

The event_b interrupt exists (and fires on certain events, if configured to do so),
but it's currently unused.

It's really optional.

> Best regards,
> Krzysztof