Re: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()

[Andrew Lunn]

On Mon, Oct 10, 2022 at 05:43:07PM +0100, Russell King (Oracle) wrote:
> On Mon, Oct 10, 2022 at 05:03:27PM +0200, Andrew Lunn wrote:
> > On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > > A helper function to check if PHY is fixed link with fwnode properties.
> > > This is similar to of_phy_is_fixed_link.
> > 
> > You need to include a user of this new function.
> > 
> > Also, not that ACPI only defines the 'new binding' for fixed-link.  If
> > this is being called on a device which is ACPI underneath, it should
> > only return true for the 'new binding', not the old binding.
> 
> Do we want to support the "managed" property in the fwnode variant,
> or persuade people to switch to phylink if they want that?

managed has been documented in
Documentation/firmware-guide/acpi/dsd/phy.rst so i think we need to
support it.

	Andrew