RE: [PATCH v6 12/12] Documentation/x86: Update resctrl_ui.rst for new features
From: Moger, Babu
Date: Mon Oct 10 2022 - 18:01:23 EST
[AMD Official Use Only - General]
Hi Reinette,
> -----Original Message-----
> From: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Sent: Monday, October 10, 2022 4:31 PM
> To: Moger, Babu <Babu.Moger@xxxxxxx>; corbet@xxxxxxx;
> tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx
> Cc: fenghua.yu@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx;
> hpa@xxxxxxxxx; paulmck@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx;
> quic_neeraju@xxxxxxxxxxx; rdunlap@xxxxxxxxxxxxx;
> damien.lemoal@xxxxxxxxxxxxxxxxxx; songmuchun@xxxxxxxxxxxxx;
> peterz@xxxxxxxxxxxxx; jpoimboe@xxxxxxxxxx; pbonzini@xxxxxxxxxx;
> chang.seok.bae@xxxxxxxxx; pawan.kumar.gupta@xxxxxxxxxxxxxxx;
> jmattson@xxxxxxxxxx; daniel.sneddon@xxxxxxxxxxxxxxx; Das1, Sandipan
> <Sandipan.Das@xxxxxxx>; tony.luck@xxxxxxxxx; james.morse@xxxxxxx;
> linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> bagasdotme@xxxxxxxxx; eranian@xxxxxxxxxx
> Subject: Re: [PATCH v6 12/12] Documentation/x86: Update resctrl_ui.rst for
> new features
>
> Hi Babu,
>
> Without opening any of the patches from this series, by just looking at the
> subject line of this patch, it was immediately clear to me that you did not follow
> my review feedback. Letting you know about the typo (resctrl_ui.rst does not
> exist) in the subject line was one of the few things I mentioned about
> v5 after v5 also did not follow review feedback from me in other areas.
>
> Providing feedback is not a good use of time if it is ignored.
I am really sorry about that. I have checked multiple over. Noticed it now, that I missed one of your comments. But I have addressed all your other comments.
I will give few days to refresh these patches. You can wait for the next revision if you like.
Thanks
Babu