Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()

[Tejun Heo]

On Mon, Oct 10, 2022 at 05:14:24PM -0700, Yosry Ahmed wrote:
> On Mon, Oct 10, 2022 at 5:11 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
> >
> > On Mon, Oct 10, 2022 at 11:58:44PM +0000, Yosry Ahmed wrote:
> > > Add cgroup_all_get_from_fd() and cgroup_all_get_from_file() that
> > > support both cgroup1 and cgroup2.
> >
> > Looks generally good. How about cgroup_v1v2_ as the prefix?
> 
> Thanks for taking a look.
> 
> I don't have a strong opinion here. I picked cgroup_all_* vs
> cgroup12_* or cgroup_v1v2_* because it's easier on the eyes.

I'd rather have something which is really distinctive because the difference
is rather subtle.

> My preference would have been to rename the old versions to
> cgroup_dfl_* instead, but like you said this might confuse existing
> users.

Yeah, it's confusing to have parallel file / id lookup functions with
different behaviors and we've asssumed that all these from-userspace lookups
are cgroup2 only for a while now.

> Anyway, I am fine with whatever you choose. Let me know if you need me
> to send a v2 for changing the prefix.

Please send an updated version. I don't mind whether it's cgroup12_ or
cgroup_v1v2_.

Thanks.

-- 
tejun