RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml

[Xu Yang]

Hi Peng,

> -----Original Message-----
> From: Jun Li <jun.li@xxxxxxx>
> Sent: Tuesday, October 11, 2022 9:51 AM
> To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>; Xu Yang <xu.yang_2@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Peng Fan
> <peng.fan@xxxxxxx>
> Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> + Xu
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Tuesday, October 11, 2022 4:25 AM
> > To: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> > Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> > linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Jun
> > Li <jun.li@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>
> > Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> >
> > On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Convert usbmisc-imx to yaml format.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> > >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > > +++++++++++++++++++
> > >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > >  create mode 100644
> > > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > deleted file mode 100644
> > > index b796836d2ce7..000000000000
> > > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > +++ /dev/null
> > > @@ -1,18 +0,0 @@
> > > -* Freescale i.MX non-core registers
> > > -
> > > -Required properties:
> > > -- #index-cells: Cells used to describe usb controller index. Should
> > > be <1>
> > > -- compatible: Should be one of below:
> > > -	"fsl,imx6q-usbmisc" for imx6q
> > > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > > -	"fsl,imx6sx-usbmisc" for imx6sx
> > > -	"fsl,imx7d-usbmisc" for imx7d
> > > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > > -- reg: Should contain registers location and length
> > > -
> > > -Examples:
> > > -usbmisc@2184800 {
> > > -	#index-cells = <1>;
> > > -	compatible = "fsl,imx6q-usbmisc";
> > > -	reg = <0x02184800 0x200>;
> > > -};
> > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > new file mode 100644
> > > index 000000000000..c0741ce9b523
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > @@ -0,0 +1,52 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id:
> > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > >
> > +cetree.org%2Fschemas%2Fusb%2Fusbmisc-imx.yaml%23&amp;data=05%7C01%7Cj
> > >
> > +un.li%40nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6f
> > >
> > +a92cd99c5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d
> > >
> > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> > >
> > +C3000%7C%7C%7C&amp;sdata=Kw6EHKfbwZ%2FfGgX6xJxML4W4E5DLiRx6pauQbLEbt0
> > > +g%3D&amp;reserved=0
> > > +$schema:
> > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > >
> > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjun.li%40
> > >
> > +nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6fa92cd99c
> > >
> > +5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> > >
> > +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > >
> > +%7C%7C&amp;sdata=akKA3n0sxbOhvwDURs%2FoV7nM680QcOQCLKgxnakRe8w%3D&amp
> > > +;reserved=0
> > > +
> > > +title: Freescale i.MX non-core registers
> > > +
> > > +maintainers:
> > > +  - Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> > Cool, is nxp going to pay me to maintain this?  If not, then don't be assigning
> > such a thing to someone else.  Why can you not maintain it?
> >
> > Assigning a file to someone without even asking them is a bit odd, please
> > never do that.
> 
> Hi Peng,
> 
> Thanks for this patchset.
> 
> Since xu.yang_2@xxxxxxx is now actively working on this IP for iMX, so he knows
> well this h/w, I guess maybe he can maintain this, @Xu Yang, can you comments on
> this?

You can assign me as maintainer temporarily.
By the way, it seems that the following compatible strings should be added too.

fsl,imx25-usbmisc
fsl,imx27-usbmisc
fsl,imx35-usbmisc
fsl,imx51-usbmisc
fsl,imx53-usbmisc

Thanks,
Xu Yang

> 
> Thanks
> Li Jun
> 
> >
> > thanks,
> >
> > greg k-h