Re: [PATCH v9 0/3] SDM670 Pin Control Driver

[Lee Jones]

On Mon, 10 Oct 2022, Richard Acayan wrote:

> > On Fri, 07 Oct 2022, Richard Acayan wrote:
> > > Richard Acayan (3):
> > >   dt-bindings: pinctrl: qcom: add sdm670 pinctrl
> > >   pinctrl: qcom: do not reinitialize gpio valid mask
> > >   pinctrl: qcom: add sdm670 pinctrl
> > > 
> > >  .../bindings/pinctrl/qcom,sdm670-tlmm.yaml    |  127 ++
> > >  drivers/pinctrl/qcom/Kconfig                  |    9 +
> > >  drivers/pinctrl/qcom/Makefile                 |    1 +
> > >  drivers/pinctrl/qcom/pinctrl-msm.c            |    3 +-
> > >  drivers/pinctrl/qcom/pinctrl-sdm670.c         | 1345 +++++++++++++++++
> > 
> > And I'm receiving this because ... ?
> 
> You wrote a patch a few years ago, then supposedly changed your email, and I
> wanted to know if there's anything we should consider before removing some of
> the code you wrote for it (in patch 2). After I added you as a recipient, it got
> a review tag, so I don't know what input you can give now (unless it's
> important). My bad for not removing you yet.

Actually that is a perfectly valid reason.  Thank you for the
clarification.  I (used to) receive 100's of reviews a week for
drivers that either have nothing to do with me or because I conducted
some basic clean-up / fixed warnings, etc.  Since I changed my email
address, things have improved a great deal, which is why this stood
out.

So I believe that patch was written to support one of the Lenovo
laptops booting in ACPI mode.  Please see sdm845_acpi_reserved_gpios
for reference.  Please ensure your patch does not break this
use-case.

Bjorn (who has now reviewed) would know this best.

-- 
Lee Jones [李琼斯]