Re: [PATCH AUTOSEL 5.10 07/10] ARM: decompressor: Include .data.rel.ro.local

From: Pavel Machek
Date: Tue Oct 11 2022 - 07:49:39 EST


Hi!

> From: Kees Cook <keescook@xxxxxxxxxxxx>
>
> [ Upstream commit 1b64daf413acd86c2c13f5443f6b4ef3690c8061 ]
>
> The .data.rel.ro.local section has the same semantics as .data.rel.ro
> here, so include it in the .rodata section of the decompressor.
> Additionally since the .printk_index section isn't usable outside of
> the core kernel, discard it in the decompressor. Avoids these warnings:
>
> arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.data.rel.ro.local'
> arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.printk_index'
>

There's no printk_index in 5.10. Perhaps this does not need to be
backported?

Best regards,
Pavel

> +++ b/arch/arm/boot/compressed/vmlinux.lds.S
> @@ -23,6 +23,7 @@ SECTIONS
> *(.ARM.extab*)
> *(.note.*)
> *(.rel.*)
> + *(.printk_index)
> /*
> * Discard any r/w data - this produces a link error if we have any,
> * which is required for PIC decompression. Local data generates
> @@ -57,6 +58,7 @@ SECTIONS
> *(.rodata)
> *(.rodata.*)
> *(.data.rel.ro)
> + *(.data.rel.ro.*)
> }
> .piggydata : {
> *(.piggydata)
> --
> 2.35.1

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature