Re: [PATCH V4 0/7] imx: blk-ctrl: Add interconnect for i.MX8MP

From: Marek Vasut
Date: Tue Oct 11 2022 - 19:13:41 EST


On 10/11/22 22:10, Tim Harvey wrote:
On Fri, Jul 8, 2022 at 1:57 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:

From: Peng Fan <peng.fan@xxxxxxx>

V4:
Because the header is not included when adding NoC node, the fsl,imx8mp.h
needs be included in this patchset. So include it in patch 6

V3:
Move adding NoC node patch to i.MX8MP ICC driver patchset
Per Lucas's comments, warn once when icc bulk get not return probe defer and continue.

V2:
Use a low bandwidth value instead INT_MAX
Minor fix to move fsl,imx8mp.h out to dts patch, not driver patch
Add A-b tag from DT maintainer

i.MX8MP NoC settings is invalid after related power domain up. So
need to set valid values after power domain up.

This patchset is to bind interconnect for each entry in blk ctrl.

This patchset is not include DVFS DDRC feature.

Peng Fan (7):
dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk
ctrl
dt-bindings: soc: imx: add interconnect property for i.MX8MP hdmi blk
ctrl
dt-bindings: soc: imx: add interconnect property for i.MX8MP hsio blk
ctrl
soc: imx: add icc paths for i.MX8MP media blk ctrl
soc: imx: add icc paths for i.MX8MP hsio/hdmi blk ctrl
arm64: dts: imx8mp: add interconnects for media blk ctrl
arm64: dts: imx8mp: add interconnect for hsio blk ctrl

.../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 9 +++++
.../soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml | 10 +++++
.../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 14 +++++++
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 18 +++++++++
drivers/soc/imx/imx8m-blk-ctrl.c | 39 +++++++++++++++++++
drivers/soc/imx/imx8mp-blk-ctrl.c | 35 +++++++++++++++++
6 files changed, 125 insertions(+)

--
2.25.1


Hi Peng,

I built origin/master from commit 041bc24d867a today for an imx8mp
board and am running into errors that appear to be introduced by this
series:
[ 15.177372] platform 381f0040.usb-phy: deferred probe pending
[ 15.183155] platform 382f0040.usb-phy: deferred probe pending
[ 15.188928] platform 33800000.pcie: deferred probe pending
[ 15.194439] platform 32ec0000.blk-ctrl: deferred probe pending
[ 15.200287] platform 38330000.blk-ctrl: deferred probe pending
[ 15.206129] platform 32f10000.blk-ctrl: deferred probe pending
[ 15.211974] platform 32f10100.usb: deferred probe pending
[ 15.217382] platform 32f10108.usb: deferred probe pending
[ 15.222791] platform cpufreq-dt: deferred probe pending
# cat /sys/kernel/debug/devices_deferred
381f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready
382f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready
33800000.pcie platform: supplier 32f10000.blk-ctrl not ready
32ec0000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries
38330000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries
32f10000.blk-ctrl imx8mp-blk-ctrl: failed to get noc entries
32f10100.usb platform: supplier 32f10000.blk-ctrl not ready
32f10108.usb platform: supplier 32f10000.blk-ctrl not ready
cpufreq-dt

Is there a driver I'm perhaps missing that is needed now or are there
some patches that come from a different unmerged tree needed?

Do you have these enabled ?

CONFIG_INTERCONNECT_IMX8MM=y
CONFIG_INTERCONNECT_IMX8MN=y
CONFIG_INTERCONNECT_IMX8MQ=y
CONFIG_INTERCONNECT_IMX8MP=y