Re: [PATCH v2] xhci: tegra: USB2 pad power controls
From: Greg KH
Date: Wed Oct 12 2022 - 05:48:06 EST
On Wed, Oct 12, 2022 at 05:40:20PM +0800, Jim Lin wrote:
> Program USB2 pad PD controls during port connect/disconnect, port
> suspend/resume, and test mode, to reduce power consumption on
> disconnect or suspend.
> Signed-off-by: Jim Lin <jilin@xxxxxxxxxx>
> v2: Fix issue that wrong tegra->phys may be accessed on tegra124
> drivers/usb/host/xhci-tegra.c | 141 +++++++++++++++++++++++++++++++++-
> 1 file changed, 139 insertions(+), 2 deletions(-)
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index c8af2cd2216d..316585068ab5 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -2,7 +2,7 @@
> * NVIDIA Tegra xHCI host controller driver
> - * Copyright (c) 2014-2020, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2014-2022, NVIDIA CORPORATION. All rights reserved.
I do not think you changed this properly. Please work with your
corporate lawyers to understand how to mark copyright changes correctly.
Then resubmit just this portion of the change with a signed-off-by: by
the lawyer so that everyone understands and agrees that it has been done
Take this portion of the diff out when you resend a v3 if you wish to
get the code changes merge sooner if your lawyers take longer than you