Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module

[Borislav Petkov]

On Wed, Sep 28, 2022 at 02:55:33PM -0700, Kuppuswamy Sathyanarayanan wrote:
> To support TDX attestation, the TDX guest user interface driver must
> use the __tdx module_call() function in the driver to allow the user to
> obtain the TDREPORT.
> 
> So export the __tdx_module_call() and move the TDX Module IDs to
> asm/tdx.h.

The functions with the __ prefix are usually lower-level interfaces
which should be internal. Usually.

Why aren't you exporting the tdx_module_call() one instead?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette