Re: [PATCH 5/7] gpiolib: of: add a quirk for reset line for Cirrus CS42L56 codec

From: Daniel Thompson
Date: Wed Oct 12 2022 - 06:30:31 EST


On Tue, Oct 11, 2022 at 03:19:33PM -0700, Dmitry Torokhov wrote:
> The controller is using non-standard "cirrus,gpio-nreset" name for its
> reset gpio property, whereas gpiod API expects "<name>-gpios".
> Add a quirk so that gpiod API will still work on unmodified DTSes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/gpio/gpiolib-of.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 7d4193fe36e5..953d1c23950a 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -407,6 +407,9 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np,
> { "wlf,ldo1ena", NULL, NULL }, /* WM8994 */
> { "wlf,ldo2ena", NULL, NULL }, /* WM8994 */
> #endif
> +#if IS_ENABLED(CONFIG_SND_SOC_CS42L56)
> + { "reset", "cirrus,gpio-nreset", "cirrus,cs42l56" },
> +#endif

Same question as before about bindings maintainance but other than that:
Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>


Daniel.