Re: [PATCH] uio_hv_generic: Enable support for slower vmbus device channels

From: Greg KH
Date: Wed Oct 12 2022 - 11:51:32 EST


On Wed, Oct 12, 2022 at 04:56:46AM -0700, Saurabh Sengar wrote:
> This patch enables support for slower vmbus channels, which consist
> of following 3 changes :
> 1. Support for hypercalls
> 2. Module params for recv/send buffer sizes
> 3. Module param for custom ring buffer sizes

Even if this all was ok, you are doing 3 things all in one change,
that's not allowed at all, you all know this.

Anyway, no new module parameters, this is not the 1990's, we have much
better ways to do this properly (hint, module parameters modify code,
you want to modify the options of a specific device.)

greg k-h