Re: [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include

From: Kees Cook
Date: Wed Oct 12 2022 - 17:52:01 EST


On Wed, Oct 12, 2022 at 04:46:44PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > Most of the details of the ram backend are entirely internal to the
> > backend itself. Leave only what is needed to instantiate a ram backend
> > in the kernel-wide header.
> >
> > Cc: Anton Vorontsov <anton@xxxxxxxxxx>
> > Cc: Colin Cross <ccross@xxxxxxxxxxx>
> > Cc: Tony Luck <tony.luck@xxxxxxxxx>
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > ---
>
> Reviewed-and-tested-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx>
>
> Tested by building and booting the kernel - since it's just header file
> rework, guess this is enough right?
>
> BTW, let me know if you prefer me to respond on the series once or per
> patch Kees (as I'm doing here).

Thanks! Yeah, per-patch is good. :)

--
Kees Cook