Re: [PATCH AUTOSEL 4.9 09/10] staging: octeon: Fix return type of cvm_oct_xmit and cvm_oct_xmit_pow
From: Greg Kroah-Hartman
Date: Thu Oct 13 2022 - 01:53:01 EST
On Wed, Oct 12, 2022 at 08:27:56PM -0400, Sasha Levin wrote:
> From: Nathan Huckleberry <nhuck@xxxxxxxxxx>
>
> [ Upstream commit b77599043f00fce9253d0f22522c5d5b521555ce ]
>
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
kCFI showed up in 6.1, so this is not needed in any stable branches,
please drop it from all.
thanks,
greg k-h