Re: [PATCH 1/1] tty: n_gsm: make n_gsm line number configurable

[Greg KH]

On Thu, Oct 13, 2022 at 11:09:02AM +0000, Starke, Daniel wrote:
> > > --- a/include/uapi/linux/gsmmux.h
> > > +++ b/include/uapi/linux/gsmmux.h
> > > @@ -19,7 +19,9 @@ struct gsm_config
> > >  	unsigned int mtu;
> > >  	unsigned int k;
> > >  	unsigned int i;
> > > -	unsigned int unused[8];		/* Padding for expansion without
> > > +	unsigned short numValid;
> > > +	unsigned short num;
> > 
> > This would never work anyway (hint "short" is not a valid uapi data
> > type...)
> 
> I am surprised about this as gsm_netconfig already uses unsigned short.

How does netconfig pass data to/from userspace?  Through ioctls or
netlink?

thanks,

greg k-h