Re: [PATCH AUTOSEL 6.0 52/77] net: sfp: re-implement soft state polling setup

[Sasha Levin]

On Mon, Oct 10, 2022 at 08:21:09AM +0100, Russell King (Oracle) wrote:
> On Sun, Oct 09, 2022 at 06:07:29PM -0400, Sasha Levin wrote:
> > From: "Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx>
> >
> > [ Upstream commit 8475c4b70b040f9d8cbc308100f2c4d865f810b3 ]
> >
> > Re-implement the decision making for soft state polling. Instead of
> > generating the soft state mask in sfp_soft_start_poll() by looking at
> > which GPIOs are available, record their availability in
> > sfp_sm_mod_probe() in sfp->state_hw_mask.
> >
> > This will then allow us to clear bits in sfp->state_hw_mask in module
> > specific quirks when the hardware signals should not be used, thereby
> > allowing us to switch to using the software state polling.
>
> NAK.
>
> There is absolutely no point in stable picking up this commit. On its
> own, it doesn't do anything beneficial. It isn't a fix for anything.
> It isn't stable material.
>
> If you picked up the next two patches in the series, there would be a
> point to it - introducing support for the HALNy GPON SFP module, but
> as you didn't these three patches on their own are entirely pointless.

So why not tag those patches for stable to make it explicit?

--
Thanks,
Sasha