Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670

[Sasha Levin]

On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote:
> > From: Richard Acayan <mailingradian@xxxxxxxxx>
> >
> > [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ]
> >
> > The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to
> > restore the dll config). Add a compatible string check to detect the need
> > for this.
> >
> > Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
> > Reviewed-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@xxxxxxxxx
> > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/mmc/host/sdhci-msm.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> > index dc2991422a87..3a091a387ecb 100644
> > --- a/drivers/mmc/host/sdhci-msm.c
> > +++ b/drivers/mmc/host/sdhci-msm.c
> > @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
> >  	 */
> >  	{.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var},
> >  	{.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var},
> > +	{.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var},
>
> Supporting device trees which are invalid under 6.0 schema? It's not a bug fix,
> it's a feature.

Does this not enable hardware to work properly? We take quirks/device
enablement into stable tree as well.

--
Thanks,
Sasha