Re: [RFC V2 PATCH 01/11] cxl/mbox: Add debug of hardware error code

From: Davidlohr Bueso
Date: Fri Oct 14 2022 - 12:53:05 EST


On Fri, 14 Oct 2022, Davidlohr Bueso wrote:
- if (mbox_cmd.return_code != CXL_MBOX_CMD_RC_SUCCESS)
+ if (mbox_cmd.return_code != CXL_MBOX_CMD_RC_SUCCESS) {
+ dev_dbg(cxlds->dev, "MB error : %s\n",

Maybe s/MB/mbox?

Actually 'Mailbox' seems to be the standard:

core/regs.c: dev_dbg(dev, "found Mailbox capability (0x%x)\n", offset);
core/regs.c: dev_dbg(dev, "found Secondary Mailbox capability (0x%x)\n", offset);
pci.c: dev_dbg(dev, "Mailbox operation had an error\n");
pci.c: dev_err(cxlds->dev, "Mailbox is too small (%zub)",
pci.c: dev_dbg(cxlds->dev, "Mailbox payload sized %zu",