Re: [PATCH v2 6/6] dt-bindings: qcom,pdc: Introduce pdc bindings for QDU1000 and QRU1000

[Krzysztof Kozlowski]

On 14/10/2022 18:10, Melody Olvera wrote:
> Add compatible fields for QDU1000 and QRU1000 pdcs.
> 
> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> index b6f56cf5fbe3..68a80e1c77c5 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> @@ -26,6 +26,8 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - qcom,qdu1000-pdc
> +          - qcom,qru1000-pdc

Un-reviewed.

Bindings do not match your DTS, so you are documenting different
hardware then upstreaming.

>            - qcom,sc7180-pdc
>            - qcom,sc7280-pdc
>            - qcom,sdm845-pdc

Best regards,
Krzysztof