Re: [PATCH v3 11/14] iio: ad7606: simplify using devm_regulator_get_enable()

[Matti Vaittinen]

On 10/16/22 19:24, Jonathan Cameron wrote:
> On Sun, 16 Oct 2022 17:15:29 +0100
> Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> > On Tue, 30 Aug 2022 15:54:07 +0300
> > Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> >
> > > Thanks for the review(s) Nuno!
> > >
> > > On 8/30/22 14:46, Sa, Nuno wrote:
> > > > > From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > > > > Sent: Friday, August 19, 2022 9:20 PM
> > > > > To: Matti Vaittinen <mazziesaccount@xxxxxxxxx>; Matti Vaittinen
> > > > > <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > > > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael
> > > > > <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron
> > > > > <jic23@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-
> > > > > kernel@xxxxxxxxxxxxxxx
> > > > > Subject: [PATCH v3 11/14] iio: ad7606: simplify using
> > > > > devm_regulator_get_enable()
> > > > >
> > > > > [External]
> > > > >
> > > > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> > > > > add_action_or_reset(regulator_disable)' and use the
> > > > > devm_regulator_get_enable() and drop the pointer to the regulator.
> > > > > This simplifies code and makes it less tempting to add manual control
> > > > > for the regulator which is also controlled by devm.
> > > > >
> > > > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > > > >
> > > > > ---
> > > >
> > > > The commit message could state that while doing the change, dev_err_probe()
> > > > was also introduced. Bah, anyways:
> > > >
> > > > Acked-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > >
> > > Good point. I have few other changes to the series pending - and I
> > > probably need to rebase/respin when -rc1 is out (and dependency patches
> > > are merged from Mark's tree) => I may as well alter the commit message.
> > >    
> > I tweaked it and applied.
> >
> > Not I'm grabbing these early because I forgot you'd sent them and
> > found myself writing the same patches.  Memory of a goldfish :)
>
> Tweaked a little more - you missed that the struct in the header had
> kernel-doc for the struct regulator *.  Dropped that.

Thanks a bunch!

Yours,
	Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~