Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue

[Yuwei Guan]

On 2022/10/17 11:38, Yu Kuai wrote:
> Hi,
>
> 在 2022/10/17 11:20, Yuwei Guan 写道:
> > it defined in d0edc2473be9d, but there's nowhere to use it,
> > so remove it.
> >
> > Signed-off-by: Yuwei Guan <Yuwei.Guan@xxxxxxxxxxxxx>
> > Acked-by: Paolo Valente <paolo.valente@xxxxxxxxxx>
> > ---
> >   block/bfq-iosched.h | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> > index 64ee618064ba..6bcef8e5871a 100644
> > --- a/block/bfq-iosched.h
> > +++ b/block/bfq-iosched.h
> > @@ -369,11 +369,8 @@ struct bfq_queue {
> >       unsigned long split_time; /* time of last split */
> >         unsigned long first_IO_time; /* time of first I/O for this 
> > queue */
> > -
> >       unsigned long creation_time; /* when this queue is created */
> >   -    /* max service rate measured so far */
> > -    u32 max_service_rate;
>
> You left two blank lines here. Have you tried checkpatch?
>
> Thanks,
> Kuai

Hi Kuai,

I checked it with checkpatch.pl, but 0 errors, 0 warnings.

I will delete one blank line, then resend it.

> >       /*
> >        * Pointer to the waker queue for this queue, i.e., to the