Re: [PATCH v5 10/13] gunyah: rsc_mgr: Add resource manager RPC core

[Dmitry Baryshkov]

On 14/10/2022 01:32, Elliot Berman wrote:
> On 10/12/2022 3:52 PM, Dmitry Baryshkov wrote:
> > On 11/10/2022 03:08, Elliot Berman wrote >> diff --git 
> > > +static int gh_msgq_platform_probe_direction(struct platform_device 
> > > *pdev,
> > > +                u8 gh_type, int idx, struct gunyah_resource *ghrsc)
> > > +{
> > > +    int ret;
> > > +    struct device_node *node = pdev->dev.of_node;
> > > +
> > > +    ghrsc->type = gh_type;
> > > +
> > > +    ghrsc->irq = platform_get_irq(pdev, idx);
> > > +    if (ghrsc->irq < 0) {
> > > +        dev_err(&pdev->dev, "Failed to get irq%d: %d\n", idx, 
> > > ghrsc->irq);
> > > +        return ghrsc->irq;
> > > +    }
> > > +
> > > +    ret = of_property_read_u64_index(node, "reg", idx, &ghrsc->capid);
> >
> > Is there any reason why can't you use platform_get_resource() here?
>
> These don't show up as resources because size-cells = 0.

Hmm, judging from of_device_alloc() / __of_address_to_resource(), the 
resources should still be created, unless I miss something.

--
With best wishes
Dmitry