Re: [PATCH] spi: qup: support using GPIO as chip select line

From: Linus Walleij
Date: Mon Oct 17 2022 - 05:19:19 EST


On Thu, Oct 6, 2022 at 9:48 PM Robert Marko <robert.marko@xxxxxxxxxx> wrote:

> Most of the device with QUP SPI adapter are actually using GPIO-s for
> chip select.
>
> However, this stopped working after ("spi: Retire legacy GPIO handling")
> as it introduced a check on ->use_gpio_descriptors flag and since spi-qup
> driver does not set the flag it meant that all of boards using GPIO-s and
> with QUP adapter SPI devices stopped working.
>
> So, to enable using GPIO-s again set ->use_gpio_descriptors to true and
> populate ->max_native_cs.
>
> Fixes: f48dc6b96649 ("spi: Retire legacy GPIO handling")
> Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> Cc: luka.perkov@xxxxxxxxxx

Ooops sorry about that!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij