Re: [PATCH v6 8/8] scsi: libsas: Update SATA dev FIS in sas_ata_task_done()

[Niklas Cassel]

On Mon, Oct 17, 2022 at 05:20:35PM +0800, John Garry wrote:
> In sas_ata_task_done(), for commands which complete with error we set
> the SATA dev FIS status field with ATA_ERR. In ata_eh_analyze_tf() this
> would be interpreted as a HSM error. Set ATA_DRDY, which will lead libata
> to judge as a device error, which is a safer bet.
> 
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>  drivers/scsi/libsas/sas_ata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 61f64d54e67d..78e6046fb55a 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -139,8 +139,8 @@ static void sas_ata_task_done(struct sas_task *task)
>  				qc->flags |= ATA_QCFLAG_FAILED;
>  			}
>  
> -			dev->sata_dev.fis[3] = 0x04; /* status err */
> -			dev->sata_dev.fis[2] = ATA_ERR;
> +			dev->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
> +			dev->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
>  		}
>  	}
>  
> -- 
> 2.35.3
> 

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>