Re: [PATCH v1 1/1] serial: 8250_core: Use str_enabled_disabled() helper

[Ilpo Järvinen]

On Mon, 17 Oct 2022, Andy Shevchenko wrote:

> Use str_enabled_disabled() helper instead of open coding the same.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 94fbf0add2ce..80a2fc2fbd4d 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,6 +32,7 @@
>  #include <linux/nmi.h>
>  #include <linux/mutex.h>
>  #include <linux/slab.h>
> +#include <linux/string_helpers.h>
>  #include <linux/uaccess.h>
>  #include <linux/io.h>
>  #ifdef CONFIG_SPARC
> @@ -1175,8 +1176,8 @@ static int __init serial8250_init(void)
>  
>  	serial8250_isa_init_ports();
>  
> -	pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %sabled\n",
> -		nr_uarts, share_irqs ? "en" : "dis");
> +	pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %s\n",
> +		nr_uarts, str_enabled_disabled(share_irqs));
>  
>  #ifdef CONFIG_SPARC
>  	ret = sunserial_register_minors(&serial8250_reg, UART_NR);
> 

Looks ok.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


-- 
 i.