Re: [PATCH 1/3] audit: cache ctx->major in audit_filter_syscall()

From: Paul Moore
Date: Mon Oct 17 2022 - 14:24:12 EST


On Wed, Sep 28, 2022 at 6:03 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Tue, Sep 27, 2022 at 6:59 PM Ankur Arora <ankur.a.arora@xxxxxxxxxx> wrote:
> >
> > ctx->major contains the current syscall number. This is, of course, a
> > constant for the duration of the syscall. Unfortunately, GCC's alias
> > analysis cannot prove that it is not modified via a pointer in the
> > audit_filter_syscall() loop, and so always loads it from memory.
> >
> > ...
> >
> > Signed-off-by: Ankur Arora <ankur.a.arora@xxxxxxxxxx>
> > ---
> > kernel/auditsc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> This looks pretty trivial to me, but it's too late in the current -rc
> cycle for this to be merged, I'll queue it up for after the upcoming
> merge window closes. Thanks.

I just merged this into audit/next, thanks again!

--
paul-moore.com