Re: [PATCH v7 0/5] Define EINVAL as device/domain incompatibility
From: Jason Gunthorpe
Date: Mon Oct 17 2022 - 19:55:09 EST
On Mon, Oct 17, 2022 at 04:00:29PM -0700, Nicolin Chen wrote:
> This series is to replace the previous EMEDIUMTYPE patch in a VFIO series:
> https://lore.kernel.org/kvm/Yxnt9uQTmbqul5lf@xxxxxxxxxx/
>
> The purpose is to regulate all existing ->attach_dev callback functions to
> use EINVAL exclusively for an incompatibility error between a device and a
> domain. This allows VFIO and IOMMUFD to detect such a soft error, and then
> try a different domain with the same device.
>
> Among all the patches, the first two are preparatory changes. And then one
> patch to update kdocs and another three patches for the enforcement effort.
>
> Although it might be ideal to merge the previous VFIO series together with
> this series, given the number of new changes, the review in the IOMMU list
> might need a couple of rounds to finalize. Also, considering that v6.0 is
> at rc5 now, perhaps we could merge this IOMMU series and the VFIO one in
> different cycles to avoid merge conflicts. If there's less concern for it,
> I can respin the finalized version of this series with the previous VFIO
> one to merge together into the VFIO tree.
>
> This series is also available on Github:
> https://github.com/nicolinc/iommufd/commits/iommu_attach_dev-v7
Since it didn't make v6.1-rc1, I'd like this on a PR as we have two
trees that will need it now.
Joerg I can make this into a formal signed PR if that is how you'd
like things?
Thanks,
Jason