Re: [PATCH -next 1/3] blktrace: introduce 'blk_trace_swicth_state' helper
From: Christoph Hellwig
Date: Tue Oct 18 2022 - 03:40:48 EST
On Mon, Oct 17, 2022 at 02:53:19PM +0800, Ye Bin wrote:
> +static int blk_trace_switch_state(struct blk_trace *bt, int start)
This is a very confusing helper. Please split it into two helpers
(e.g. blk_trace_{start,stop}) instead of the awakward int used as
boolean argument that makes it do two entirely unrelated things.