Re: [PATCH 1/2] mmc: mtk-sd: add Inline Crypto Engine support

[AngeloGioacchino Del Regno]

Il 17/10/22 16:20, Mengqi Zhang ha scritto:
> add crypto clock control and ungate it before CQHCI init.
>
> Signed-off-by: Mengqi Zhang <mengqi.zhang@xxxxxxxxxxxx>

Hello Mengqi,
I'm a bit surprised that enabling ICE only requires enabling a clock as
on downstream code I see some SMC calls to MTK_SIP_KERNEL_HW_FDE_MSDC_CTL.

Can you please explain why SMC calls are not needed here?

Thanks,
Angelo