Re: [PATCH] perf report: Skip symbols for idle symbols

[Rafał Miłecki]

On 8.06.2022 07:51, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> Displaying idle symbols is rather useless and makes reviewing "real"
> symbols harder. perf top already skips them so perf report should
> probably do the same.
>
> BEFORE
>
> # Overhead  Command          Shared Object          Symbol
> # ........  ...............  .....................  ...................................
> #
>      75.04%  swapper          [kernel.kallsyms]      [k] arch_cpu_idle
>       1.05%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
>       0.78%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
>       0.75%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
>       0.58%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
>       0.56%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
>       0.55%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
>       0.53%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc
>
> AFTER
>
> # Overhead  Command          Shared Object          Symbol
> # ........  ...............  .....................  ...................................
> #
>       4.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
>       3.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
>       3.01%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
>       2.32%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
>       2.23%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
>       2.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
>       2.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc
>       2.00%  ksoftirqd/0      [kernel.kallsyms]      [k] eth_type_trans
>       1.86%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_rx
>       1.73%  ksoftirqd/0      [kernel.kallsyms]      [k] __local_bh_enable_ip
>       1.63%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_rules_lookup
>       1.61%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_tx
>       (...)
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Ping? Does it look OK to you?