Re: [PATCH v2 2/2] module: Merge same-name module load requests
From: Luis Chamberlain
Date: Tue Oct 18 2022 - 14:33:17 EST
On Sat, Oct 15, 2022 at 11:27:10AM +0200, Petr Pavlu wrote:
> The patch does address a regression observed after commit 6e6de3dee51a
> ("kernel/module.c: Only return -EEXIST for modules that have finished
> loading"). I guess it can have a Fixes tag added to the patch.
>
> I think it is hard to split this patch into parts because the implemented
> "optimization" is the fix.
git describe --contains 6e6de3dee51a
v5.3-rc1~38^2~6
I'm a bit torn about this situation. Reverting 6e6de3dee51a would be the
right thing to do, but without it, it still leaves the issue reported
by Prarit Bhargava. We need a way to resolve the issue on stable and
then your optimizations can be applied on top.
Prarit Bhargava, please review Petry's work and see if you can come up
with a sensible way to address this for stable.
Luis