RE: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__

[Keller, Jacob E]

> -----Original Message-----
> From: yexingchen116@xxxxxxxxx <yexingchen116@xxxxxxxxx>
> Sent: Monday, October 17, 2022 6:52 PM
> To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; joe@xxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; ye xingchen
> <ye.xingchen@xxxxxxxxxx>
> Subject: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__
> 
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
> 
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
> 
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>

Thanks for cleaning this up!

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

> ---
> v1 -> v2
> Fix the message up to use ("message in %s\n", __func__)
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..efa2692af577 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>  		iavf_close(netdev);
> 
>  	if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> -		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in
> %s\n", __FUNCTION__);
> +		dev_warn(&adapter->pdev->dev, "%s: failed to acquire
> crit_lock\n", __func__);
>  	/* Prevent the watchdog from running. */
>  	iavf_change_state(adapter, __IAVF_REMOVE);
>  	adapter->aq_required = 0;
> --
> 2.25.1