Re: [PATCH V3 1/2] dt-bindings: firmware: qcom-scm: Add optional interrupt

[Sibi Sankar]

Hey Krzysztof,
Thanks for taking time to review the series.

On 10/18/22 10:41 PM, Krzysztof Kozlowski wrote:
> On 18/10/2022 05:46, Sibi Sankar wrote:
> > From: Guru Das Srinagesh <quic_gurus@xxxxxxxxxxx>
> >
> > Add an interrupt specification to the bindings to support the wait-queue
> > feature.
> >
> > Signed-off-by: Guru Das Srinagesh <quic_gurus@xxxxxxxxxxx>
> > Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> > ---
> >
> > The interrupt property for scm firmware from a binding perspective is
> > completely optional i.e. not all tz fw running in the wild on sm8450
> > devices support this feature. The bootloader does the interrupt property
> > addition on sm8450 devices with wait-queue support.
> >
> >   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > index c5b76c9f7ad0..6483d76b2371 100644
> > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > @@ -71,6 +71,11 @@ properties:
> >     '#reset-cells':
> >       const: 1
> >   
> > +  interrupts:
> > +    description:
> > +      The wait-queue interrupt that firmware raises as part of handshake
> > +      protocol to handle sleeping SCM calls.
>
> You still miss here constraints... nothing improved. Just look at other
> properties in this file.
>
> maxItems:1

Ack. Missed adding it in the re-spin.

-Sibi

> Best regards,
> Krzysztof