Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+

[Neil Armstrong]

Hi Anand,

On 19/10/2022 11:48, Anand Moon wrote:
> Hi Martin,
>
> On Wed, 19 Oct 2022 at 08:36, Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> > Hi Martin,
> >
> > On Wed, 19 Oct 2022 at 02:46, Martin Blumenstingl
> > <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
> > > Hello Anand,
> > >
> > > On Tue, Oct 18, 2022 at 9:53 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> > > > Odroid N2/N2+ support active cooling via gpio-fan controller.
> > > > Add fan controls and tip point for cpu and ddr thermal sensor
> > > > on this boards.
> > > In the schematics for board rev 0.6 [0] I cannot find any information
> > > about a fan connector.
> > > The schematics for board rev 0.3 [1] on the other hand document a PWM
> > > based fan connector on page 16.
> > > So now I am not sure whether your patch only applies to certain board
> > > revisions, the schematics are incorrect, etc.
> > >
> > > Can you please provide some details about the fan connector on
> > > Odroid-N2/N2+ and which hardware revisions are supported (and which
> > > aren't) by your patch?
> > Ok I got this wrong the schematics below there is pwm controller, not
> > gpio controller
> > GPIOAO.BIT10 (PWM)
> > I will correct the patch sorry for the mistake I did not look more carefully.
>
> As per the schematics GPIOAO_10 is controlled by PWMAO_D
> But looking into the datasheet [0] I could not find the relevant
> PWMAO_D pmw ip block to link the fan to the PWM controller.
>
> [0] https://dn.odroid.com/S922X/ODROID-N2/Datasheet/S922X_Public_Datasheet_V0.2.pdf
>
> I could get the PWM node but is not working for me.
>
> @@ -547,6 +588,14 @@ &pwm_ab {
>          status = "okay";
>   };
>
> +&pwm_AO_ab {

&pwm_AO_cd not _ab

> +       pinctrl-1 = <&pwm_ao_d_10_pins>;
> +       pinctrl-names = "default";
> +       clocks = <&xtal>;
> +       clock-names = "clkin0";
> +       status = "okay";
> +};
> +
>
> Thanks
> -Anand
>
>
> > > Thank you!
> > > Martin
> > >
> > >
> > > [0] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf
> > > [1] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.3_20190117.pdf
> > Thanks
> > -Anand

Neil