Re: [PATCH v4] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm

[Uwe Kleine-König]

On Wed, Oct 19, 2022 at 05:42:18PM +0800, xinlei.lee@xxxxxxxxxxxx wrote:
> From: xinlei lee <xinlei.lee@xxxxxxxxxxxx>
> 
> In the original mtk_disp_pwm_get_state() function wrongly uses bit 0 of
> CON0 to judge if the PWM is enabled.
> However that is indicated by a bit (at a machine dependent position) in
> the DISP_PWM_EN register. Fix this accordingly.
> 
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
> Signed-off-by: xinlei lee <xinlei.lee@xxxxxxxxxxxx>

Nice commit log text :-)

This now matches the bit that the .apply() callback sets, so looks
right.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature